[bugfix] fix AWS triggers where deserialization would crash if region was not specified #32729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was not specified the region is not serialized if it's None, so if a trigger has a non-optional region and we pass `None` to it manually, it doesn't get serialized, and the code crashes when trying to rebuild the trigger from the serialized params, complaining about a missing "region_name" argument.
boring-cyborg
bot
added
area:providers
provider:amazon-aws
vandonr-amz
commented
Jul 20, 2023
There was a problem hiding this comment.
those triggers were merged yesterday, so no trouble in rearranging the arguments, it's not breaking compared to released code.
vincbeck
approved these changes
Jul 20, 2023
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the region is not serialized if it's None, so if a trigger has a non-optional region and we pass
Noneto it manually, it doesn't get serialized, and the code crashes when trying to rebuild the trigger from the serialized params, complaining about a missing "region_name" argument.airflow/airflow/providers/amazon/aws/triggers/base.py
Lines 103 to 105 in 05f1acf