Add missing execute_complete method for DatabricksRunNowOperator
#32689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanikumv
reviewed
Jul 19, 2023
Lee-W
force-pushed
the
add-missing-execute-complete-to-DatabricksRunNowOperator
branch
from
67dc7a4
to
d41cdd1
Compare
phanikumv
approved these changes
Jul 19, 2023
eladkal
changed the title
DatabricksRunNowOperator
…tabricksRunNowOperator
…n DatabricksRunNowDeferrableOperator this has been moved to DatabricksRunNowOperator
|
@Lee-W static checks are failing |
Lee-W
force-pushed
the
add-missing-execute-complete-to-DatabricksRunNowOperator
branch
from
d41cdd1
to
72e7046
Compare
|
@phanikumv Yes, there was a test failure after the fixing. Just fixed and pushed. Let see whether everything works 💪 |
Lee-W
force-pushed
the
add-missing-execute-complete-to-DatabricksRunNowOperator
branch
from
a35c4a1
to
f5f15d8
Compare
|
It's green now |
phanikumv
deleted the
add-missing-execute-complete-to-DatabricksRunNowOperator
branch
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DatabricksRunNowOperator, we runs _handle_deferrable_databricks_operator_execution whic needs a
execute_completemethod. As this method does not exist, this task will fail. In this PR, I added thisexecute_completemethod from DatabricksRunNowDeferrableOperator^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.