Allow templates in cleanup.schedule #32570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
approved these changes
Jul 12, 2023
ephraimbuddy
added
the
changelog:skip
pgvishnuram
pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is quite simple in that it allows helm templates to be used in the value of
cleanup.schedule. This also works with strings, which makes the change backwards compatible, so it will have no impact on existing installations. Shout out to @jedcunningham and @dstandish for helping me settle on this very simple syntax change.There were no tests for
cleanup.schedule, so I added tests, including tests for using strings and for using helm template logic.FWIW, the test logic shows an example of using adler32sum to select a deterministic random-ish number, seeded by
.Release.Name, to use as the starting minute for the cleanup cronjob. This mechanism will avoid starting all cleanup jobs across all deployments on minute 0, and was the impetus for changing from string to a template.