Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3ToRedshiftOperator does not support default values on UPSERT #32558

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

dashton90
Copy link
Contributor

This commit corrects a bug where upserts fail into tables with default, non-null columns

closes: #30341

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 12, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@cjames23
Copy link
Contributor

@eladkal this looks good to me and was the approach I was going to take when I had planned on cutting a PR Friday.

@eladkal eladkal changed the title Handle default column values when upserting from S3 into Redshift Fix S3ToRedshiftOperator does not support default values on UPSERT Jul 13, 2023
@eladkal eladkal merged commit 145b16c into apache:main Jul 13, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 13, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3ToRedshiftOperator does not support default values on upsert
4 participants