Hide sensitive values from extra in connection edit form #32309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
potiuk
force-pushed
the
draft-connection-sensitive
branch
from
34ebc62 to
7d89461
Compare
potiuk
force-pushed
the
draft-connection-sensitive
branch
2 times, most recently
from
9330ba0 to
c80894c
Compare
uranusjr
reviewed
Jul 3, 2023
potiuk
force-pushed
the
draft-connection-sensitive
branch
from
c80894c to
6cc1cec
Compare
uranusjr
reviewed
Jul 4, 2023
uranusjr
reviewed
Jul 4, 2023
uranusjr
reviewed
Jul 4, 2023
potiuk
force-pushed
the
draft-connection-sensitive
branch
2 times, most recently
from
8b66185 to
9aad051
Compare
The fields that are sensitive (i.e password field is used to show them in Connection edit view) should also be hidden when they are stored as "extra" in the form extra field. This PR handles both - replacing such values with a placeholder as well as not updating the value if the placeholder has not been modified.
potiuk
force-pushed
the
draft-connection-sensitive
branch
from
9aad051 to
3b105b3
Compare
|
Should be ready! |
eladkal
approved these changes
Jul 5, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 6, 2023
The fields that are sensitive (i.e password field is used to show them in Connection edit view) should also be hidden when they are stored as "extra" in the form extra field. This PR handles both - replacing such values with a placeholder as well as not updating the value if the placeholder has not been modified. (cherry picked from commit d012483)
53 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields that are sensitive (i.e password field is used to show them in Connection edit view) should also be hidden when they are stored as "extra" in the form extra field.
This PR handles both - replacing such values with a placeholder as well as not updating the value if the placeholder has not been modified.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.