Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pydantic 2 pickiness about model definition #32307

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jul 1, 2023

The new Pydantic 2 has been released on 30th of June and it is a bit more picky about model definition, thus causing Airflow to fail because there were wrong definitions of models (previously corretly validated).

Fixes: #32301


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The new Pydantic 2 has been released on 30th of June and it is a
bit more picky about model definition, thus causing Airflow to
fail because there were wrong definitions of models (previously
corretly validated).

Fixes: apache#32301
@potiuk potiuk merged commit 4d84e30 into apache:main Jul 1, 2023
@potiuk potiuk deleted the fix-pydantic-2-errors branch July 1, 2023 21:42
@potiuk potiuk added this to the Airlfow 2.6.3 milestone Jul 1, 2023
potiuk added a commit that referenced this pull request Jul 2, 2023
The new Pydantic 2 has been released on 30th of June and it is a
bit more picky about model definition, thus causing Airflow to
fail because there were wrong definitions of models (previously
corretly validated).

Fixes: #32301
(cherry picked from commit 4d84e30)
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:serialization type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

= instead of : in type hints - failing Pydantic 2
3 participants