Update references to restructured documentation from airflow core #32282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
added
full tests needed
potiuk
requested review from
ephraimbuddy,
mobuchowski,
hussein-awala and
eladkal
pankajkoti
approved these changes
Jun 30, 2023
hussein-awala
approved these changes
Jun 30, 2023
pankajastro
approved these changes
Jun 30, 2023
phanikumv
approved these changes
Jun 30, 2023
|
Ah. I know why it succeded in #32131. Fix coming separately :) |
The change apache#32131 restructured some of the code for documentation and it broke references to apache-airlfow from "providers" doc package - it has not been visible in selective PR (not sure the reason) but this PR fixes it.
potiuk
force-pushed
the
fix-references-to-updated-airflow-docs
branch
from
e9f01cf to
ce8a2e5
Compare
|
Sphinx 🤯 ... I had to also bring old reference to google provider to make it succeed. |
|
OK. Docs succeeded. Merging. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 30, 2023
When provider docs in "docs/apache-airflow-providers" changed, and selective docs build was used, the "apache-airflow-providers" package was not added to the filter - thus errors in those docs were not checked. This caused apache#32131 to fail the main build (fixed in the apache#32282). Added logic to handle this case.
potiuk
added a commit
that referenced
this pull request
Jun 30, 2023
…32284) When provider docs in "docs/apache-airflow-providers" changed, and selective docs build was used, the "apache-airflow-providers" package was not added to the filter - thus errors in those docs were not checked. This caused #32131 to fail the main build (fixed in the #32282). Added logic to handle this case.
potiuk
added a commit
that referenced
this pull request
Jul 2, 2023
…32284) When provider docs in "docs/apache-airflow-providers" changed, and selective docs build was used, the "apache-airflow-providers" package was not added to the filter - thus errors in those docs were not checked. This caused #32131 to fail the main build (fixed in the #32282). Added logic to handle this case. (cherry picked from commit ba05a1e)
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change #32131 restructured some of the code for documentation and it broke references to apache-airlfow from "providers" doc package - it has not been visible in selective PR (not sure the reason) but this PR fixes it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.