Flash an error msg instead of failure in rendered-templates when map index is not found
#32011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hussein Awala <[email protected]>
hussein-awala
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
uranusjr
reviewed
Jun 20, 2023
airflow/www/views.py
Outdated
| ti.refresh_from_task(raw_task) | ||
| else: | ||
| # When there is no task instance with the given map_index | ||
| ti = TaskInstance(raw_task, map_index=map_index) |
There was a problem hiding this comment.
I would prefer this to do something more explicit. It is very awkward to instantiate a fake task instance without any intention to run it.
There was a problem hiding this comment.
could you check it now?
Here is the result on the UI:
There was a problem hiding this comment.
Do we want to keep the Rendered Template line in the empty tab? (That’s title I think?) Maybe we can change it to a Markup object that shows some details on the error.
Signed-off-by: Hussein Awala <[email protected]>
hussein-awala
force-pushed
the
fix/rendered_templates
branch
from
e132cd1 to
92d7b66
Compare
uranusjr
approved these changes
Jun 21, 2023
pierrejeambrun
approved these changes
Jun 24, 2023
eladkal
approved these changes
Jun 25, 2023
potiuk
approved these changes
Jun 25, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 27, 2023
…p index is not found (apache#32011) --------- Signed-off-by: Hussein Awala <[email protected]>
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 6, 2023
…p index is not found (#32011) --------- Signed-off-by: Hussein Awala <[email protected]> (cherry picked from commit 62a534d)
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #32005
Before this PR:
After this PR:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.