-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix number param html type in trigger template #31980
Fix number param html type in trigger template #31980
Conversation
…hange only type value Signed-off-by: Hussein Awala <[email protected]>
{%- if "integer" in form_details.schema.type %} valuetype="number" {% elif "number" in form_details.schema.type %} valuetype="decimal" {%- endif %} | ||
{%- if "integer" in form_details.schema.type or "number" in form_details.schema.type %} valuetype="number"{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So just to make sure, this PR reverts this line from #31946 and the aggregated change is only line 120, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because we need just to change type
attribute
Co-authored-by: Tzu-ping Chung <[email protected]>
* Keep valuetype="number" for both param number and integer types and change only type value Signed-off-by: Hussein Awala <[email protected]> * Update airflow/www/templates/airflow/trigger.html Co-authored-by: Tzu-ping Chung <[email protected]> --------- Signed-off-by: Hussein Awala <[email protected]> Co-authored-by: Tzu-ping Chung <[email protected]> (cherry picked from commit 2327718)
related: #31930
related: #31946
It seems that when I changed the
valuetype
todecimal
, the value was passed to the API a string which raise a validation exception in the dag run. Changing just the type to decimal is sufficient to fix the initial issue, for ex:^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.