Fix operator_extra_links property serialization in mapped tasks
#31904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
changed the title
operator_extra_links property serialization in mapped tasksoperator_extra_links property serialization in mapped tasks
uranusjr
reviewed
Jun 28, 2023
potiuk
approved these changes
Jul 3, 2023
uranusjr
approved these changes
Jul 4, 2023
uranusjr
reviewed
Jul 4, 2023
| @@ -287,7 +287,7 @@ class BaseSerialization: | |||
| _datetime_types = (datetime.datetime,) | |||
|
|
|||
| # Object types that are always excluded in serialization. | |||
| _excluded_types = (logging.Logger, Connection, type) | |||
| _excluded_types = (logging.Logger, Connection, type, property) | |||
There was a problem hiding this comment.
if we don't exclude it, the serialized object will have both operator_extra_links (added by the method serialize_to_json with the method as value) and _operator_extra_links, also the property type should be excluded anyway because it is not deserialized.
uranusjr
approved these changes
Jul 6, 2023
eladkal
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #31902
This PR checks if the
operator_extra_linksis defined as a class property to load the parameter from it instead of loading the property instance^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.