openlineage, docs: tips for OpenLineage method implementation #31817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
kind:documentation
provider:openlineage
phanikumv
reviewed
Jun 12, 2023
pankajkoti
approved these changes
Jun 13, 2023
uranusjr
reviewed
Jun 13, 2023
| How to properly implement OpenLineage methods? | ||
| ============================================== | ||
|
|
||
| There are several things worth noting when implementing OpenLineage in operators. |
There was a problem hiding this comment.
Suggested change
| There are several things worth noting when implementing OpenLineage in operators. | |
| There are a couple of things worth noting when implementing OpenLineage in operators. |
I was anticipating a third thing when reading this, but there seems to be only two?
There was a problem hiding this comment.
Hmm, I was referring to everything below that line. I guess that's unclear, tried to fix this.
sunank200
suggested changes
Jun 13, 2023
phanikumv
reviewed
Jun 13, 2023
|
|
||
| First, do not import OpenLineage methods on top-level, but in OL method itself. | ||
| This allows users to use your provider even if they do not have OpenLineage provider installed. | ||
|
|
There was a problem hiding this comment.
can we add an example here (or) link to an already existing example? The example will be useful for folks who are starting out on a new OL implementation
There was a problem hiding this comment.
Added example from GcsToGcsOperator - due to it's simplicity.
mobuchowski
force-pushed
the
openlineage-docs-additions
branch
from
4c1f75c
to
65c2e40
Compare
mobuchowski
force-pushed
the
openlineage-docs-additions
branch
from
65c2e40
to
9a48c9f
Compare
Signed-off-by: Maciej Obuchowski <[email protected]>
mobuchowski
force-pushed
the
openlineage-docs-additions
branch
from
9a48c9f
to
7a41a13
Compare
|
@sunank200 added section on writing tests. I assume system test PR will be merged in similar shape it's today, if not I'll update the section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tips for provider contributors on how to effectively add OpenLineage support.