Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation update on Plugin updates. #31781

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Documentation update on Plugin updates. #31781

merged 4 commits into from
Jun 8, 2023

Conversation

vijayasarathib
Copy link
Contributor

Updated the documentation to reflect the fact that the Tasks forked by Local Executor will not be impacted with a module reboot.

closes: #30796

@vijayasarathib
Fix for issue apache#30796
06d26bd 
Tasks forked by the Local Executor are loading stale modules when the modules are also referenced by plugins apache#30796
@vijayasarathib vijayasarathib requested a review from potiuk as a code owner June 7, 2023 19:58
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 7, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit 18f2b35 into apache:main Jun 8, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 8, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal eladkal added this to the Airlfow 2.6.3 milestone Jun 17, 2023
@eladkal eladkal added the type:doc-only Changelog: Doc Only label Jun 17, 2023
ephraimbuddy pushed a commit that referenced this pull request Jul 6, 2023
@vijayasarathib @ephraimbuddy
Documentation update on Plugin updates. (#31781)
d21a599 
* Fix for  issue #30796

Tasks forked by the Local Executor are loading stale modules when the modules are also referenced by plugins #30796

(cherry picked from commit 18f2b35)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adaverse Adaverse Adaverse left review comments

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
area:plugins kind:documentation type:doc-only Changelog: Doc Only
Projects
None yet
Milestone
Airflow 2.6.3
Development

Successfully merging this pull request may close these issues.

Tasks forked by the Local Executor are loading stale modules when the modules are also referenced by plugins
4 participants
@vijayasarathib @potiuk @Adaverse @eladkal