Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws provider unused async code #31610

Merged
merged 1 commit into from
Jun 4, 2023
Merged

Conversation

pankajastro
Copy link
Member

  • Removed RedshiftClusterTrigger and corresponding test since not getting used
  • Deprecate BaseAsyncSessionFactory AwsBaseAsyncHook and RedshiftAsyncHook

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels May 30, 2023
@pankajastro pankajastro changed the title Remove aws unused code Remove aws provider unused async code May 30, 2023
@pankajastro pankajastro marked this pull request as ready for review June 4, 2023 18:28
@potiuk potiuk merged commit f69dd29 into apache:main Jun 4, 2023
@uranusjr uranusjr deleted the clean_async_aws branch June 5, 2023 06:25
@yjdlau
Copy link

yjdlau commented Jun 27, 2023

Why are you deprecating AwsBaseAsyncHook???? Any discussions???

@yjdlau yjdlau mentioned this pull request Jun 27, 2023
2 tasks
@pankajastro
Copy link
Member Author

Why are you deprecating AwsBaseAsyncHook???? Any discussions???

We decided to use boto waiter for aws deferrable operators in PR #30032 so aws async hook is not getting used in the airflow codebase because of that I have deprecated it and we will remove it in future aws provider major releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants