Fix timestamp parse failure for k8s executor pod tailing #31175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
dstandish
requested review from
jedcunningham
and removed request for
jedcunningham
uranusjr
reviewed
May 10, 2023
When we tail stdout over kube API, we get ansi color codes which must be escaped in order for timestamps to be properly parsed so that messages can be properly interleaved by the file task handler (i.e. / a.k.a. the web UI task log reader). While at it, fixed an issue with improper appending of "messages" (e.g. "fetching logs from kube API") and added one such message for good measure.
dstandish
force-pushed
the
k8s-executor-log-fetch-timestamp-parse-fix
branch
from
9b25182 to
d015efb
Compare
jedcunningham
approved these changes
May 10, 2023
uranusjr
approved these changes
May 11, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
May 11, 2023
(cherry picked from commit 86d62d3)
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we tail stdout over kube API, we get ansi color codes which must be escaped in order for timestamps to be properly parsed so that messages can be properly interleaved by the file task handler (i.e. / a.k.a. the web UI task log reader).
While at it, fixed an issue with improper appending of "messages" (e.g. "fetching logs from kube API") and added one such message for good measure.
Before:
After:
