AWS logs. Exit fast when 3 consecutive responses are returned from AWS Cloudwatch logs #30756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S Cloudwatch logs
boring-cyborg
bot
added
area:providers
provider:amazon-aws
eladkal
reviewed
Apr 20, 2023
Comment on lines
30
to
31
| # The issue with this approach is, it can take a huge amount of time (e.g. 20 seconds) to retrieve logs | ||
| # As an intermediate solution, we decided to stop fetching logs if 3 consecutive responses are empty |
There was a problem hiding this comment.
if that happens what user is expected to do / how would user know that this is the issue ?
There was a problem hiding this comment.
He would not be able to know. Before #20814, we were stopping fetching logs after one response from CW is empty. After #20814 being introduced, we now wait that the next token is the same in 2 consecutive responses. We now shoot in the middle to satisfy a bit of the two worlds. This fix is very empirical based on user experiences. They get a very frustrated experience where, sometimes, they need to wait 20 seconds to retrieve logs
o-nikolas
approved these changes
Apr 20, 2023
ferruzzi
reviewed
Apr 21, 2023
| else: | ||
| token_arg = {} | ||
|
|
||
| response = self.get_conn().get_log_events( | ||
| response = self.conn.get_log_events( |
There was a problem hiding this comment.
Thanks for including this update ❤️
ferruzzi
approved these changes
Apr 21, 2023
o-nikolas
approved these changes
Apr 21, 2023
This was referenced Apr 21, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue had been introduced by #20814. Now, it takes customers 20 seconds or more to load task logs from past executions. As a solution we decided to exit when 3 consecutive empty responses are returned from AWS Cloudwatch logs
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.