add a stop operator to emr serverless #30720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
provider:amazon-aws
vincbeck
requested changes
Apr 18, 2023
vincbeck
requested changes
Apr 18, 2023
docs/apache-airflow-providers-amazon/operators/emr/emr_serverless.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent <[email protected]>
Co-authored-by: Vincent <[email protected]>
vincbeck
approved these changes
Apr 19, 2023
vincbeck
requested changes
Apr 19, 2023
Co-authored-by: Vincent <[email protected]>
vincbeck
approved these changes
Apr 19, 2023
o-nikolas
approved these changes
Apr 19, 2023
This was referenced Apr 21, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMR serverless currently has a
deleteoperator that stops the app and deletes it, but there is no operator to just stop an app.Since the delete operator contains a stop step, to avoid duplicating the code, I made it inherit from the new stop operator.
Usually, composition is preferred over inheritance, but in this case, since they are operators, I cannot really create an operator inside another because an operator is an object that is more complex than just the action it executes. Creating an operator inside an other operator creates new tasks in the DAG, requires a different task_id, etc.
tagging for visibility: @vincbeck @syedahsn @ferruzzi