Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install twine with --force for package verification #30683

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Apr 17, 2023

In some cases when the machine has been reused across builds, pipx installed twine might seem both installed and removed (this happens when builds are cancelled while installing twine.

Installing twine with --force should fix the problem.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

In some cases when the machine has been reused across builds, pipx
installed twine might seem both installed and removed (this happens
when builds are cancelled while installing twine.

Installing twine with --force should fix the problem.
@potiuk
Copy link
Member Author

potiuk commented Apr 17, 2023

Should fix the problem observed in https://github.com/apache/airflow/actions/runs/4722563664/jobs/8377395906?pr=30588 for example.

We do not cache twine pipx install, it makes very little sense as twine is super small and likely saving/restoring cache will take longer than installing it, hovever there are some cases where it will seem that twine is already installed where it is not.

@potiuk potiuk merged commit b7a3a16 into apache:main Apr 17, 2023
@potiuk potiuk deleted the install-twine-with-force branch April 17, 2023 17:03
wookiist pushed a commit to wookiist/airflow that referenced this pull request Apr 19, 2023
In some cases when the machine has been reused across builds, pipx
installed twine might seem both installed and removed (this happens
when builds are cancelled while installing twine.

Installing twine with --force should fix the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants