Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQueryGetDataOperator should use project_id #30651

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

ying-w
Copy link
Contributor

@ying-w ying-w commented Apr 14, 2023

When calling BigQueryGetDataOperator without selected_fields the function will look up the schema using hook.get_schema(). Currently, this lookup doesn't use project_id, this PR fixes that and closes #30635

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Apr 14, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 14, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@hussein-awala hussein-awala merged commit 4eab616 into apache:main Apr 15, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 15, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

wookiist pushed a commit to wookiist/airflow that referenced this pull request Apr 19, 2023
@ying-w ying-w deleted the fix-gcp-project-id branch April 24, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQueryGetDataOperator does not respect project_id parameter
2 participants