Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmailOperator: fix wrong assignment of from_email #30524

Merged
merged 8 commits into from
Apr 7, 2023
Merged

EmailOperator: fix wrong assignment of from_email #30524

merged 8 commits into from
Apr 7, 2023

Conversation

vanducng
Copy link
Contributor

@vanducng vanducng commented Apr 7, 2023

  • The EmailOperator call the smtp_hook.send_email_smtp function with mis-ordered of prams which caused unexpected email subject & content.

Hook function: (subject -> html_content -> from_email)
image

Operator execution call: (from_email -> subject -> html_content)
image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 7, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@vanducng
Copy link
Contributor Author

vanducng commented Apr 7, 2023

@hussein-awala @eladkal I saw this provider was initiated/reviewed in last 3 weeks by you two, kindly help review the fix. Thanks.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we need more unit tests on this operator, I'll add them in a separate PR. LGTM

@eladkal eladkal changed the title fix(operators): [smtp] Wrong input params order EmailOperator: fix wrong assignment of from_email Apr 7, 2023
Copy link
Contributor

@ephraimbuddy ephraimbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the send_email_smtp take only keyword arguments to avoid this mistake with any other operator

@potiuk
Copy link
Member

potiuk commented Apr 7, 2023

Let's make the send_email_smtp take only keyword arguments to avoid this mistake with any other operator

Agree.

@vanducng
Copy link
Contributor Author

vanducng commented Apr 7, 2023

Let's make the send_email_smtp take only keyword arguments to avoid this mistake with any other operator

Can you help to review again?

@eladkal
Copy link
Contributor

eladkal commented Apr 7, 2023

tests are failing :(

@eladkal eladkal merged commit a15e734 into apache:main Apr 7, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 7, 2023

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants