-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmailOperator
: fix wrong assignment of from_email
#30524
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
@hussein-awala @eladkal I saw this provider was initiated/reviewed in last 3 weeks by you two, kindly help review the fix. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we need more unit tests on this operator, I'll add them in a separate PR. LGTM
EmailOperator
: fix wrong assignment of from_email
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the send_email_smtp
take only keyword arguments to avoid this mistake with any other operator
Agree. |
Can you help to review again? |
tests are failing :( |
Awesome work, congrats on your first merged pull request! |
Hook function: (subject -> html_content -> from_email)
Operator execution call: (from_email -> subject -> html_content)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.