-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up nested TaskGoups #30284
Speed up nested TaskGoups #30284
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
2f5f34b
to
17972c7
Compare
How much speedup does this produce? The |
7d272a3
to
2cdafad
Compare
@uranusjr |
2cdafad
to
458baf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me and should be OK to be merged. One more potential path to optimise things though; feel free to investigate in another PR.
5d36f35
to
2f6e26b
Compare
acbf148
to
cd613c5
Compare
cd613c5
to
ffe1d15
Compare
@uranusjr, thanks for approving. Any expected timeline for merging this and including it in a new release? |
You just broke the PR… |
it's a rebase done from the Ui while github had a bug https://github.com/orgs/community/discussions/51948 |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Co-authored-by: eladkal <[email protected]>
This PR aims to speed up nested TaskGroups. During the checks in conditions the Task won't have to go into 'depth' to figure out the group_id.
This affects particularly cases where there is deep nesting of TaskGroups.