-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EC2CreateInstanceOperator
, EC2TerminateInstanceOperator
#29548
Add EC2CreateInstanceOperator
, EC2TerminateInstanceOperator
#29548
Conversation
a5f0b41
to
6e4650d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty solid, just some small comments but one that should be addressed related to unpacking an arg.
6e4650d
to
ccf8984
Compare
879922e
to
2be47c1
Compare
EC2CreateInstanceOperator
, EC2TerminateInstanceOperator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small docstring update, but LGTM!
c34ff0b
to
e5a84e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
will merge when CI is green
Seems like the "Wait for CI images" step failure could be related?
|
1190b8a
to
41c1751
Compare
Change system test to use the new operators Add unit tests for new operators
Change system test to terminate without stopping instances
…tiple instances Add tests for creating/terminating multiple instances
Fix doc string on EC2TerminateInstanceOperator
41c1751
to
1a4e537
Compare
This PR creates two new operators
EC2CreateInstanceOperator
andEC2TerminateInstanceOperator
which will be used to create and terminate EC2 instances respectively. The system test has been updated to use the new operators.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.