-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bitnami/postgresql helm depenency from 10.5.3 to 12.1.9 #29071
Merged
potiuk
merged 1 commit into
apache:main
from
snjypl:27353-upgrade-postgresql-helm-chart-to-12.1.9
Jan 21, 2023
Merged
Upgrade bitnami/postgresql helm depenency from 10.5.3 to 12.1.9 #29071
potiuk
merged 1 commit into
apache:main
from
snjypl:27353-upgrade-postgresql-helm-chart-to-12.1.9
Jan 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snjypl
force-pushed
the
27353-upgrade-postgresql-helm-chart-to-12.1.9
branch
from
January 20, 2023 20:09
39fa10f
to
89da656
Compare
potiuk
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also add the original author as co-author
snjypl
force-pushed
the
27353-upgrade-postgresql-helm-chart-to-12.1.9
branch
from
January 20, 2023 20:30
89da656
to
8119198
Compare
jedcunningham
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also verified the tarball came from bitnami.
snjypl
force-pushed
the
27353-upgrade-postgresql-helm-chart-to-12.1.9
branch
from
January 20, 2023 21:01
8119198
to
54e8588
Compare
This version of the chart uses different variable names for setting usernames and passwords in the postgres database. `postgresql.auth.enablePostgresUser` is used to determine if the "postgres" admin account will be created. `postgresql.auth.postgresPassword` sets the password for the "postgres" user. `postgresql.auth.username` and `postrgesql.auth.password` are used to set credentials for a non-admin account if desired. `postgresql.postgresqlUsername` and `postgresql.postresqlPassword`, which were used in the previous version of the chart, are no longer used. Users will need to change these variable names in their values files if they are using the helm chart. Co-authored-by: Caleb Woofenden <[email protected]>
snjypl
force-pushed
the
27353-upgrade-postgresql-helm-chart-to-12.1.9
branch
from
January 20, 2023 23:56
54e8588
to
8b69b1c
Compare
maggesssss
pushed a commit
to maggesssss/airflow
that referenced
this pull request
Jan 21, 2023
…he#29071) This version of the chart uses different variable names for setting usernames and passwords in the postgres database. `postgresql.auth.enablePostgresUser` is used to determine if the "postgres" admin account will be created. `postgresql.auth.postgresPassword` sets the password for the "postgres" user. `postgresql.auth.username` and `postrgesql.auth.password` are used to set credentials for a non-admin account if desired. `postgresql.postgresqlUsername` and `postgresql.postresqlPassword`, which were used in the previous version of the chart, are no longer used. Users will need to change these variable names in their values files if they are using the helm chart. Co-authored-by: Caleb Woofenden <[email protected]>
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 28, 2023
….9 (apache#29071)" This reverts commit 5da085b.
28 tasks
2 tasks
ephraimbuddy
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Apr 11, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:dev-tools
area:helm-chart
Airflow Helm Chart
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #27353
this is a continuation of #27357. i fixed the failing unittests
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.