Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Provider Package release 7.0.0 - Add description of breaking changes #28582

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

dwreeves
Copy link
Contributor

This PR is by request from @potiuk here: #28505 (comment)

He wanted a succinct description of the breaking changes I introduced. I mention that JSON secrets for the AWS SecretsManagerBackend no longer do anything regarding urlencoding. I added a sub-bullet to clarify how this differs from the 5.x change, since at first glance they seem like they're indistinguishable changes.

The changelog is meant to be very short and to the point. To keep things brief, I omitted two things:

  • I do not mention the removal of ast.literal_eval() for json.loads because this was never a documented behavior, and a reasonable coder should have known better than to use invalid JSONs.
  • I also never mention that get_conn_value() can return a JSON because as of 6.1.0, the AWS provider package was already locked in base Airflow version >=2.3.0 where this behavior is already assumed to be a supported (i.e. the base implementation for the method get_connection() calls get_conn_value(), and then checks whether it is a JSON or URL).

I'm not sure exactly how you want this formatted so let me know.

@dwreeves dwreeves requested a review from eladkal as a code owner December 24, 2022 21:44
@dwreeves dwreeves changed the title add description of breaking changes Amazon Provider Package release 7.0.0 - Add description of breaking changes Dec 24, 2022
@dwreeves dwreeves force-pushed the aws-provider-changelog branch from 3f2c89a to 6bc687d Compare December 25, 2022 19:30
@dwreeves dwreeves force-pushed the aws-provider-changelog branch from 68acca5 to 0b5a32b Compare December 27, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants