Amazon Provider Package release 7.0.0 - Add description of breaking changes #28582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is by request from @potiuk here: #28505 (comment)
He wanted a succinct description of the breaking changes I introduced. I mention that JSON secrets for the AWS
SecretsManagerBackend
no longer do anything regarding urlencoding. I added a sub-bullet to clarify how this differs from the 5.x change, since at first glance they seem like they're indistinguishable changes.The changelog is meant to be very short and to the point. To keep things brief, I omitted two things:
ast.literal_eval()
forjson.loads
because this was never a documented behavior, and a reasonable coder should have known better than to use invalid JSONs.get_conn_value()
can return a JSON because as of 6.1.0, the AWS provider package was already locked in base Airflow version>=2.3.0
where this behavior is already assumed to be a supported (i.e. the base implementation for the methodget_connection()
callsget_conn_value()
, and then checks whether it is a JSON or URL).I'm not sure exactly how you want this formatted so let me know.