Add FTPSFileTransmitOperator #28318
Merged
Add FTPSFileTransmitOperator #28318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferruzzi
reviewed
Dec 12, 2022
ferruzzi
reviewed
Dec 12, 2022
ferruzzi
reviewed
Dec 12, 2022
RachitSharma2001
force-pushed
the
ftps_transmit
branch
2 times, most recently
from
924a6c9 to
008fcd5
Compare
ferruzzi
reviewed
Dec 12, 2022
RachitSharma2001
force-pushed
the
ftps_transmit
branch
2 times, most recently
from
ca524b1 to
fdfa6bf
Compare
ferruzzi
reviewed
Dec 15, 2022
| ftp_conn_id="ftps_default", | ||
| local_filepath="/tmp/filepath", | ||
| remote_filepath="/remote_tmp/filepath", | ||
| operation=FTPOperation.PUT, |
There was a problem hiding this comment.
Just want to double check this is intentional and not supposed to be FTPSOperation.PUT
There was a problem hiding this comment.
Yes that is intentional, as FTPS still uses the same operations (PUT and GET) as FTPFileTransmitOperator. On second thought, I was wondering if that name is misleading. Do you think I should change the name to something like Operation or something?
There was a problem hiding this comment.
I think it should be alright.
|
Left a last question. If that's good to go then I think it looks good. |
Taragolis
reviewed
Dec 15, 2022
RachitSharma2001
force-pushed
the
ftps_transmit
branch
from
fdfa6bf to
ad93964
Compare
RachitSharma2001
force-pushed
the
ftps_transmit
branch
from
ad93964 to
914a6fc
Compare
|
Hi everyone, I was wondering if I could get some additional reviews on this PR? No rush, but was just wondering if these changes look good or if there is anything else that should be added. |
Taragolis
approved these changes
Dec 20, 2022
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding issue: #26531
I have added the
FTPSFileTransmitOperator, which allows for writing to files in FTPS servers and downloading them to the local directory. I have also updated the docs and system tests for this new operator.I have also added a few more tests in the
tests/providers/ftp/operatorsdirectory. Because the only difference between theFTPFileTransmitOperatorandFTPSFileTransmitOperatoris the use of theFTPSHook(as opposed to theFTPHook), I only added unit tests that tested the functionality and use of theFTPSHookwithin theFTPSFileTransmitOperator.