-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EmrAddStepsOperature wait_for_completion parameter is not working #28052
Fix EmrAddStepsOperature wait_for_completion parameter is not working #28052
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Could you add a unit test? Having a unit would have avoided this issue :)
@vincbeck |
@2h-kim also static checks failed. You should follow STATIC_CODE_CHECKS guide and install |
@Taragolis Thank you for your kind explanation. As you said, I used 'pre-commit' and checked that there is a quote(') problem. |
Still a static check to fix :( |
Co-authored-by: Vincent <[email protected]>
Rebased the PR as it was too far behind main. |
Awesome work, congrats on your first merged pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I think you probably forgot to test for wait_for_completion = true
case.
When use airflow with EmrAddStepsOperature with wait_for_completion=False it isn't work because in excute, add_job_flow_steps function use
wait_for_completion=True
.When modified, it was confirmed that it turned well.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.