Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EmrAddStepsOperature wait_for_completion parameter is not working #28052

Merged
merged 14 commits into from
Dec 19, 2022

Conversation

2h-kim
Copy link
Contributor

@2h-kim 2h-kim commented Dec 2, 2022

When use airflow with EmrAddStepsOperature with wait_for_completion=False it isn't work because in excute, add_job_flow_steps function use wait_for_completion=True.
When modified, it was confirmed that it turned well.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@2h-kim 2h-kim requested a review from eladkal as a code owner December 2, 2022 09:22
@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Dec 2, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 2, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Could you add a unit test? Having a unit would have avoided this issue :)

@2h-kim
Copy link
Contributor Author

2h-kim commented Dec 4, 2022

Nice catch! Could you add a unit test? Having a unit would have avoided this issue :)

@vincbeck
I added unit test code by referring to your advice. But it's my first time unit test with mock, so can you check if I wrote it well? :)

@Taragolis
Copy link
Contributor

@2h-kim also static checks failed. You should follow STATIC_CODE_CHECKS guide and install pre-commit, unless you want to change everything manually.

@2h-kim
Copy link
Contributor Author

2h-kim commented Dec 5, 2022

@Taragolis Thank you for your kind explanation. As you said, I used 'pre-commit' and checked that there is a quote(') problem.

@potiuk
Copy link
Member

potiuk commented Dec 5, 2022

Still a static check to fix :(

@eladkal eladkal mentioned this pull request Dec 6, 2022
@eladkal
Copy link
Contributor

eladkal commented Dec 8, 2022

Rebased the PR as it was too far behind main.
will merge once CI is green

@eladkal eladkal merged commit e377e86 into apache:main Dec 19, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 19, 2022

Awesome work, congrats on your first merged pull request!

@2h-kim 2h-kim deleted the airflow-provider-aws-emr-addstep branch December 19, 2022 15:25
Copy link

@deban9017 deban9017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I think you probably forgot to test for wait_for_completion = true case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants