add some important log in aws athena hook #27917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BobDu <[email protected]>
boring-cyborg
bot
added
area:providers
provider:amazon-aws
pierrejeambrun
approved these changes
Nov 27, 2022
eladkal
reviewed
Nov 27, 2022
Signed-off-by: BobDu <[email protected]>
Signed-off-by: BobDu <[email protected]>
uranusjr
reviewed
Dec 1, 2022
Comment on lines
116
to
120
| self.log.error( | ||
| "Exception while getting query state %s. Query execution id: %s", | ||
| ex, | ||
| query_execution_id, | ||
| ) |
There was a problem hiding this comment.
Do we want to use log.exception instead? (Same for other calls below)
There was a problem hiding this comment.
I'm not sure if we should use log.exception .
In this PR I just added query execution id in the log message.
There was a problem hiding this comment.
@uranusjr I modify it to use log.exception
uranusjr
reviewed
Dec 1, 2022
Signed-off-by: BobDu <[email protected]>
vincbeck
reviewed
Dec 2, 2022
| @@ -91,8 +94,12 @@ def run_query( | |||
| } | |||
| if client_request_token: | |||
| params["ClientRequestToken"] = client_request_token | |||
| if self.log_query: | |||
There was a problem hiding this comment.
What is the reason why we want to use a flag (log_query) to configure whether we log or not? In other words, why dont we log regardless ?
There was a problem hiding this comment.
Oops! I missed that. Thanks for pointing it out. LGTM
vincbeck
approved these changes
Dec 2, 2022
potiuk
approved these changes
Dec 5, 2022
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: BobDu [email protected]
add some important log in aws athena hook
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.