Patch "checked" when pod not successful #27845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
uranusjr
reviewed
Nov 23, 2022
dstandish
commented
Dec 1, 2022
| if not self.is_delete_operator_pod: | ||
| with _suppress(Exception): | ||
| self.patch_already_checked(remote_pod) | ||
| if pod_phase != PodPhase.SUCCEEDED or not self.is_delete_operator_pod: |
There was a problem hiding this comment.
this line (the addition of "or pod not successful") is the key change in this PR.
We patch not just if "is delete" but also any time tha pod phase is not successful.
this is to ensure that if the pod takes a long time to get removed (or if it simply failed to start in the first place) that we make sure we don't reattach to it on the retry.
everything else is drive by refactor / cleanup
dstandish
force-pushed
the
kpo-always-patch
branch
from
9205c33 to
fbabcc1
Compare
uranusjr
approved these changes
Dec 1, 2022
In KPO, if pod gets stuck in terminating status, then we might keep reattaching to it.
dstandish
force-pushed
the
kpo-always-patch
branch
from
fbabcc1 to
2d84e5a
Compare
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In KPO, if pod gets stuck in terminating status, then we might keep reattaching to it.
the key change is the the addition of "or pod not successful" to the conditions for patching the pod as "checked"
We patch not just if "is delete" but also any time tha pod phase is not successful.
this is to ensure that if the pod takes a long time to get removed (or if it simply failed to start in the first place) that we make sure we don't reattach to it on the retry.
everything else is drive by refactor / cleanup