-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix show user info error #27537
Fix show user info error #27537
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chyok for the PR. Just to understand were you able to consistently reproduce this?
Yes, it is very easy to reproduce. |
Nice! |
Awesome work, congrats on your first merged pull request! |
Hi,
closes: #27479
I found that this code will permanently delete the userinfoedit key in the context of the entire process
widgets['show'].template_args['actions'].pop('userinfoedit')
In fact, it will affect self.actions so the next deletion will be reported key error.
An interesting phenomenon is that when you refresh the page, there is a certain probability of success, but the number of successes will not exceed the number of your workers, because the "actions" of each process are affected.
setting a default value can solve this problem.