Move static checks to single-line ones #27424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suddenly github stopped liking 3-years old (otherwise perfectly fine) double-quoted mutli-line strings indented in the way that they lacked spaces (even it is perfectly valid yaml). Seems they changed parser to be a lot more picky (and rather wrong because such multi-line entries when ended with \ are perfectly fine according to yaml specification. This change fixes the problem by making those keys single line and telling yamlling to ignore their length (yammlint was the main reason why they were converted into multi-line keys).
ephraimbuddy
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suddenly github stopped liking 3-years old (otherwise perfectly fine) double-quoted mutli-line strings indented in the way that they lacked spaces (even it is perfectly valid yaml). Seems they changed parser to be a lot more picky (and rather wrong because such multi-line entries when ended with \ are perfectly fine according to yaml specification.
This change fixes the problem by making those keys single line and telling yamlling to ignore their length (yammlint was the main reason why they were converted into multi-line keys).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.