-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate error handler for 405(Method not allowed) errors #26880
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
dd41868
to
f2d1fc8
Compare
Static checks are failing - I suggest to install pre-commit locally (it will even fix things for you and running BTW. I will not be available for next two weeks (vacations) so I hope @uranusjr or someone else will merge it before :) |
f2d1fc8
to
68bb3e8
Compare
Fixed the static check issues, need approval to run the workflow again. @uranusjr, do take a look if you can 😄 |
68bb3e8
to
c9526fe
Compare
Awesome work, congrats on your first merged pull request! |
Co-authored-by: Dakshin K <[email protected]> (cherry picked from commit 8efb678)
Co-authored-by: Dakshin K <[email protected]> (cherry picked from commit 8efb678)
Previously, the webserver was using the same error handler for both 404 and 405 errors, and returning a 'Not Found' response for both cases. Hence the response status code was always 404, even when a 405(Method not allowed) was raised internally.
This PR creates a separate error handler for 405 errors, so it will return an appropriate response and status code.
closes: #26375
Results of manual testing