Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one_done trigger rule #26146

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Add one_done trigger rule #26146

merged 4 commits into from
Sep 23, 2022

Conversation

pankajastro
Copy link
Member

@pankajastro pankajastro commented Sep 3, 2022

closes: #26099

1

2

3

4

5

6

7

8


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@raphaelauv
Copy link
Contributor

one_done -> at_least_one_done

cause one_done mean one and only one upstream task must be done

wdyt ?

@uranusjr
Copy link
Member

uranusjr commented Sep 6, 2022

We already have one_success and one_failed, IMO one_done fits better.

@pankajastro pankajastro marked this pull request as ready for review September 8, 2022 12:42
@pankajastro pankajastro changed the title [WIP] Add one_done trigger rule Add one_done trigger rule Sep 8, 2022
@eladkal eladkal added this to the Airflow 2.4.0 milestone Sep 8, 2022
@ashb ashb modified the milestones: Airflow 2.4.0, Airflow 2.5.0 Sep 8, 2022
@potiuk
Copy link
Member

potiuk commented Sep 18, 2022

Can someone more involved in trigger rules take a look at this one? @uranusjr @ashb - seems good to me in general, but maybe it can be done simpler :)

@kaxil kaxil merged commit baaea09 into apache:main Sep 23, 2022
@kaxil kaxil deleted the one_done_trigger_rule branch September 23, 2022 17:05
@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add one_done trigger rule
8 participants