Set template_fields on RDS operators #26005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
provider:amazon-aws
hankehly
commented
Aug 27, 2022
| @@ -41,35 +43,6 @@ def create_sns_topic(env_id) -> str: | |||
| return boto3.client('sns').create_topic(Name=f'{env_id}-topic')['TopicArn'] | |||
|
|
|||
|
|
|||
| @task | |||
| def create_rds_instance(db_name, instance_name) -> None: | |||
There was a problem hiding this comment.
I made the same updates in each system test file
|
@o-nikolas @vincbeck @ferruzzi @potiuk |
potiuk
approved these changes
Aug 27, 2022
vincbeck
approved these changes
Aug 29, 2022
ferruzzi
reviewed
Aug 29, 2022
Co-authored-by: D. Ferruzzi <[email protected]>
|
Cool, thanks for the change. LGTM. |
|
@o-nikolas @vincbeck @ferruzzi @potiuk |
kaxil
approved these changes
Sep 5, 2022
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #24099 #25952
Summary
This PR sets the
template_fieldsproperty onRdsCreateDbInstanceOperatorandRdsDeleteDbInstanceOperatorto allow users to programmatically change the database id, instance size, allocated storage, etc..It also replaces use of
@taskdecorated functions with their appropriate operator in system tests.Todo
template_fieldsto RDS operators