Fix S3Hook transfer config arguments validation #25544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
Taragolis
force-pushed
the
fix-transfer-config-args-validation
branch
from
7df6bbb to
fa31b5b
Compare
uranusjr
reviewed
Aug 5, 2022
Taragolis
force-pushed
the
fix-transfer-config-args-validation
branch
from
a5615dc to
465ebc8
Compare
uranusjr
approved these changes
Aug 5, 2022
potiuk
approved these changes
Aug 5, 2022
This was referenced Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect validation for
transfer_config_args.Additional reminder for me if something seems simple and do not required tests - this might cause an issues 🙄
In additional replace
ValueErrorbyTypeErrorsince we check type of arguments