Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Smart Sensors #25507

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Remove Smart Sensors #25507

merged 5 commits into from
Aug 4, 2022

Conversation

ashb
Copy link
Member

@ashb ashb commented Aug 3, 2022

It was deprecated in 2.3 and since it is experimental we can now remove
it -- Deferrable operators is a much more efficient pattern to achieve
the same feature.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:core-operators Operators, Sensors and hooks within Core Airflow area:logging area:providers area:Scheduler including HA (high availability) scheduler area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation provider:Apache labels Aug 3, 2022
@ashb ashb force-pushed the remove-smart-sensors branch 2 times, most recently from bcb4e7a to 3f48a5a Compare August 3, 2022 11:17
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another -1700 lines of code :)

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some more refrences in docs:

sensors.rst:

Smart Sensors take a bit more setup; for more information on them, see :doc:`smart-sensors`.

deferring.rst:

@ashb ashb requested a review from dstandish as a code owner August 4, 2022 09:27
@ashb ashb requested a review from jedcunningham August 4, 2022 09:47
ashb added 5 commits August 4, 2022 14:36
It was deprecated in 2.3 and since it is experimental we can now remove
it -- Deferrable operators is a much more efficient pattern to achieve
the same feature.
@ashb ashb force-pushed the remove-smart-sensors branch from 566d0ed to bc9c9d7 Compare August 4, 2022 13:36
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashb ashb merged commit 7e3d235 into apache:main Aug 4, 2022
@ashb ashb deleted the remove-smart-sensors branch August 4, 2022 15:24
@eladkal eladkal added this to the Airflow 2.4.0 milestone Aug 4, 2022
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:core-operators Operators, Sensors and hooks within Core Airflow area:logging area:providers area:Scheduler including HA (high availability) scheduler area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants