Use 'python3' instead of 'python' in scripts #25499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These scripts are run in the *host*, not a container, so they should reference 'python3' explicitly to make sure they get a useful Python version. According to PEP 394, 'python' could refer to Python 2 in a global environment, so 'python3' should be preferred for scripts.
|
Ah right. They are not run in |
potiuk
approved these changes
Aug 3, 2022
potiuk
pushed a commit
that referenced
this pull request
Aug 4, 2022
These scripts are run in the *host*, not a container, so they should reference 'python3' explicitly to make sure they get a useful Python version. According to PEP 394, 'python' could refer to Python 2 in a global environment, so 'python3' should be preferred for scripts. (cherry picked from commit 87a0bd9)
ephraimbuddy
added
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These scripts are run in the host, not a container, so they should reference
python3explicitly to make sure they get a useful Python version. According to PEP 394,pythoncould refer to Python 2 in a global environment, sopython3should be preferred for scripts.