Make tag fetching when preparing providers optional. #25236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @PatrykKlimowicz |
Tag fetching is only needed to make sure we do not generate packages that have already been generated. However this is just an optimisation for CI runs. There is no harm if the tags are not refreshed and we generate the package again locally. Tag fetching might faile in various cases - for example when you are in corporate environment and require specific certificates to be available or when you are working from a worktree. After this change fetching tag will produce warning when there is an error and instruction on how you can fetch tags manually.
potiuk
force-pushed
the
make-git-tag-refresh-optional
branch
from
197338c to
e2977cb
Compare
2 tasks
josh-fell
approved these changes
Jul 22, 2022
Co-authored-by: Josh Fell <[email protected]>
potiuk
added a commit
that referenced
this pull request
Aug 4, 2022
* Make tag fetching when preparing providers optional. Tag fetching is only needed to make sure we do not generate packages that have already been generated. However this is just an optimisation for CI runs. There is no harm if the tags are not refreshed and we generate the package again locally. Tag fetching might faile in various cases - for example when you are in corporate environment and require specific certificates to be available or when you are working from a worktree. After this change fetching tag will produce warning when there is an error and instruction on how you can fetch tags manually. * Update dev/provider_packages/prepare_provider_packages.py Co-authored-by: Josh Fell <[email protected]> Co-authored-by: Josh Fell <[email protected]> (cherry picked from commit 1aaf206)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag fetching is only needed to make sure we do not generate
packages that have already been generated. However this is just
an optimisation for CI runs. There is no harm if the tags are
not refreshed and we generate the package again locally.
Tag fetching might faile in various cases - for example when
you are in corporate environment and require specific certificates
to be available or when you are working from a worktree.
After this change fetching tag will produce warning when there is
an error and instruction on how you can fetch tags manually.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.