Implement XComArg.zip(*xcom_args) #25176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
aip-42-xcom-arg-zip
branch
8 times, most recently
from
1b9d0b9 to
dba1d6c
Compare
ashb
reviewed
Jul 28, 2022
ashb
approved these changes
Jul 29, 2022
This will be needed to implementing zip() since zipping means combining multiple upstream tasks' values into one. All existing implementations reference one single task right now.
With the foundation layed down, this is relatively straightforward. The only thing we need to be aware is the make the resolved value index-able, and thus cannot use the built-in zip() (which returns an iterator).
uranusjr
force-pushed
the
aip-42-xcom-arg-zip
branch
from
13bd59e to
98833b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs #25085 to be merged first.Currently submitted for CI so I know I’ve made the right refactoring…This is mostly done. If #25173 is merged first, I want to also addDonezip()to the type hint stub. If this is merged before #25173, we can add the hint with a new PR later.There are two parts in this PR. The first part (commit) refactors XComArg to make it naturally reference multiple XComs, instead of just one key in one operator. This also involves some changes in abstraction is task mapping and serialisation. The second commit actually implements
zip(), and is relatively simple since all the foundation has been layed in the refactoring part.