Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow re-use of decorated task groups #25160

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

Pocoder
Copy link
Contributor

@Pocoder Pocoder commented Jul 19, 2022

There is no way to change group_id of @task_group decorated function (TaskGroupDecorator) outside of its declaration.
I am following the same style that was proposed in solving the same problem for @task decorated functions #22941:

@task_group
def simple_tg():
   ...

@dag
def simple_dag():
    tg = simple_tg.override(group_id='other_id')()

Also this feature allows to change other kwargs of TaskGroup:

@dag
def simple_dag2():
    tg = simple_tg.override(default_args={
        'pool': 'mypool',
    })()

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 19, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uranusjr - wdyt? Seems like it might work.

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be great for reusing collections of tasks among repeatable patterns in DAGs. ❤️

@potiuk potiuk merged commit b815e22 into apache:main Jul 22, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 22, 2022

Awesome work, congrats on your first merged pull request!

@Pocoder Pocoder deleted the add-override-to-task-group-decorator branch July 23, 2022 17:49
@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Aug 14, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants