-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YandexCloud provider: Support new Yandex SDK features for DataProc #25158
Conversation
9a00214
to
a16eed7
Compare
@potiuk hey Jarek, I'm not sure what to do with CI, guide me please. Based on README in generated/ dir, I'm not sure if I am supposed to modify this file by hand. What would you suggest to do? |
You should simply run pre-commit and commit what has been generated. |
It's actually explained at the bottom of the error you see in static checks and here are the docs: https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#pre-commit-hooks |
And feel free to add in the README that you should commit the changes generated by pre-commit (and also you could add link to https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#pre-commit-hooks ). Ideally you are the best person to phrase it correctly as you misunderstood what I was trying to tell there - so if you can improve the README description that woudl be fantastic. |
That makes sense, thanks! I guess I was not sure if pre-commit should happen on my side or on CI side. |
a16eed7
to
07304e6
Compare
54f69ac
to
b4efd79
Compare
Rebased to account for Werkzeug failures, but likely there are tests to address anyway |
b4efd79
to
682bdbb
Compare
Not sure if fails are related to changes of this PR;
and
Do not seem related to this PR for me. |
Yep. You modify dependencies so you also upgrade all others, and those errors are indeed happening in main (or were happening) - one of them I already fixed (the warning). The other I know what causes it and (new flask-login) and I am fixing it shortly. Bad luck - you attempted to update dependencies (via provider.yaml) when other dependencies broke main. 🤷 |
Oh, makes sense, thanks for the explanation. Please let me know if I can help in any way. |
682bdbb
to
6b3a99e
Compare
Just rebased it (I fixed both problem and merged the fix today). If it works and we merge it - it will get released. |
Support following parameters in DataprocCreateClusterOperator:
properties
initialization_actions
enable_ui_proxy
security_group_pds
Support creation of DataProc clusters with no datanodes and S3 instead of HDFS
Add example for direct usage of yandexcloud SDK connection in custom operators
Functionality is tested on local AirFlow installation.