Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YandexCloud provider: Support new Yandex SDK features for DataProc #25158

Merged
merged 5 commits into from
Jul 29, 2022

Conversation

Piatachock
Copy link
Contributor

Support following parameters in DataprocCreateClusterOperator:

  • properties
  • initialization_actions
  • enable_ui_proxy
  • security_group_pds

Support creation of DataProc clusters with no datanodes and S3 instead of HDFS

Add example for direct usage of yandexcloud SDK connection in custom operators


Functionality is tested on local AirFlow installation.

@Piatachock Piatachock force-pushed the dataproc_new_features branch 2 times, most recently from 9a00214 to a16eed7 Compare July 20, 2022 10:59
@Piatachock
Copy link
Contributor Author

@potiuk hey Jarek, I'm not sure what to do with CI, guide me please.
I've got a dependency version update in this PR, so I updated provider.yaml file. Now CI fails on check on generated/provider_dependencies.yaml file: https://github.com/apache/airflow/runs/7428106267?check_suite_focus=true

Based on README in generated/ dir, I'm not sure if I am supposed to modify this file by hand. What would you suggest to do?

@potiuk
Copy link
Member

potiuk commented Jul 21, 2022

You should simply run pre-commit and commit what has been generated.

@potiuk
Copy link
Member

potiuk commented Jul 21, 2022

It's actually explained at the bottom of the error you see in static checks and here are the docs: https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#pre-commit-hooks

@potiuk
Copy link
Member

potiuk commented Jul 21, 2022

And feel free to add in the README that you should commit the changes generated by pre-commit (and also you could add link to https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#pre-commit-hooks ). Ideally you are the best person to phrase it correctly as you misunderstood what I was trying to tell there - so if you can improve the README description that woudl be fantastic.

@Piatachock
Copy link
Contributor Author

That makes sense, thanks! I guess I was not sure if pre-commit should happen on my side or on CI side.
I'll see if there is other way to phrase it in README

@Piatachock Piatachock force-pushed the dataproc_new_features branch from a16eed7 to 07304e6 Compare July 25, 2022 08:09
@potiuk potiuk force-pushed the dataproc_new_features branch from 54f69ac to b4efd79 Compare July 25, 2022 16:27
@potiuk
Copy link
Member

potiuk commented Jul 25, 2022

Rebased to account for Werkzeug failures, but likely there are tests to address anyway

@Piatachock Piatachock force-pushed the dataproc_new_features branch from b4efd79 to 682bdbb Compare July 26, 2022 11:54
@Piatachock
Copy link
Contributor Author

Not sure if fails are related to changes of this PR;

Unknown warnings generated:
[1393](https://github.com/apache/airflow/runs/7520766090?check_suite_focus=true#step:12:1400)
  /usr/local/lib/python3.7/site-packages/snowflake/connector/options.py:99:You have an incompatible version of 'pyarrow' installed (6.0.1), please install a version that adheres to: 'pyarrow<8.1.0,>=8.0.0; extra == "pandas"'
...
  ERROR! There were 1 warnings generated during the import

and

[13951](https://github.com/apache/airflow/runs/7520766090?check_suite_focus=true#step:10:13965)
tests/providers/google/common/auth_backend/test_google_openid.py F...... [ 74%]
...
>           assert "[email protected]" == current_user.email
[14171](https://github.com/apache/airflow/runs/7520766090?check_suite_focus=true#step:10:14185)
E           AttributeError: 'AnonymousUser' object has no attribute 'email'

Do not seem related to this PR for me.

@potiuk
Copy link
Member

potiuk commented Jul 26, 2022

Yep. You modify dependencies so you also upgrade all others, and those errors are indeed happening in main (or were happening) - one of them I already fixed (the warning). The other I know what causes it and (new flask-login) and I am fixing it shortly. Bad luck - you attempted to update dependencies (via provider.yaml) when other dependencies broke main.

🤷

@Piatachock
Copy link
Contributor Author

Oh, makes sense, thanks for the explanation. Please let me know if I can help in any way.
On the other hand, we at Yandex would be happy to pack this PR in next providers release; I would be on vacation for next week, but if we can help to make this happen - please let me or @peter-volkov know

@potiuk potiuk force-pushed the dataproc_new_features branch from 682bdbb to 6b3a99e Compare July 27, 2022 14:04
@potiuk
Copy link
Member

potiuk commented Jul 27, 2022

Just rebased it (I fixed both problem and merged the fix today). If it works and we merge it - it will get released.

@potiuk potiuk merged commit a61e0c1 into apache:main Jul 29, 2022
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:system-tests changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants