-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump typing-extensions and mypy for ParamSpec #25088
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice! Let's see how many errors it will produce to fix though :) |
potiuk
approved these changes
Jul 15, 2022
I want to use them in some @task signature improvements. Mypy added this in 0.950, but let's just bump to latest since why not. Changelog of typing-extensions is spotty before 4.0, but ParamSpec was introduced some time before that (likely some time in 2021), and it seems to be a reasonble minimum to bump to. For more about ParamSpec, read PEP 612: https://peps.python.org/pep-0612/
uranusjr
force-pushed
the
upgrade-mypy-paramspec
branch
from
July 16, 2022 04:38
3661895
to
4fc583e
Compare
uranusjr
requested review from
ashb,
mik-laj,
jedcunningham,
kaxil and
XD-DENG
as code owners
July 16, 2022 04:38
uranusjr
force-pushed
the
upgrade-mypy-paramspec
branch
from
July 16, 2022 09:43
4fc583e
to
3dba524
Compare
Oh no |
Alright, the failures are fixed. I am not sure with a lot of the changes I made, so please lend an eye if you could. |
potiuk
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce!
All looks legit! |
potiuk
pushed a commit
that referenced
this pull request
Jul 21, 2022
* Bump typing-extensions and mypy for ParamSpec I want to use them in some @task signature improvements. Mypy added this in 0.950, but let's just bump to latest since why not. Changelog of typing-extensions is spotty before 4.0, but ParamSpec was introduced some time before that (likely some time in 2021), and it seems to be a reasonble minimum to bump to. For more about ParamSpec, read PEP 612: https://peps.python.org/pep-0612/ (cherry picked from commit e32e9c5)
This was referenced Aug 10, 2022
ephraimbuddy
added
the
type:misc/internal
Changelog: Misc changes that should appear in change log
label
Aug 15, 2022
ephraimbuddy
added
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
type:misc/internal
Changelog: Misc changes that should appear in change log
and removed
type:misc/internal
Changelog: Misc changes that should appear in change log
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
labels
Aug 15, 2022
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use them in some
@task
signature improvements. Mypy added this in 0.950, but let's just bump to latest since why not.Changelog of typing-extensions is spotty before 4.0, but ParamSpec was introduced some time before that (likely some time in 2021), and it seems to be a reasonble minimum to bump to.
See PEP 612 for more about ParamSpec if you’re interested. But in short, it solves our problem when typing
@task
—the resulting task should accept the same arguments as the wrapped function inside, but when called should return an XComArg, instead of the wrapped function’s return value.