Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grid date ticks #24738

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Fix grid date ticks #24738

merged 3 commits into from
Jun 29, 2022

Conversation

bbovenzi
Copy link
Contributor

In #24684 I accidentally broke the date ticks above the dag run bars in the grid view. We weren't counting them correctly and this led to some odd scroll overlapping.

Bug:
Screen Shot 2022-06-29 at 11 33 57 AM

This PR adds tests to detect this issue and then fixes it.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jun 29, 2022
@bbovenzi
Copy link
Contributor Author

bbovenzi commented Jun 29, 2022

Looks like static checks were failing. So also fixing a type checking issue introduced earlier

@bbovenzi bbovenzi merged commit d725625 into apache:main Jun 29, 2022
@bbovenzi bbovenzi deleted the fix-grid-date-ticks branch June 29, 2022 17:01
@jedcunningham jedcunningham added this to the Airflow 2.3.3 milestone Jun 29, 2022
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Jun 29, 2022
ephraimbuddy pushed a commit that referenced this pull request Jun 30, 2022
* fix date ticks

* fix linting

* fix LinkButton type error

(cherry picked from commit d725625)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants