Fix behaviour of build/pull after recent Breeze changes #24657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
commented
Jun 25, 2022
potiuk
commented
Jun 25, 2022
potiuk
force-pushed
the
fix-pull-build-behaviour-of-breeze-after-recent-changes
branch
5 times, most recently
from
da30c3c to
ab4b7e9
Compare
|
Nees #24659 to succeed. |
potiuk
force-pushed
the
fix-pull-build-behaviour-of-breeze-after-recent-changes
branch
2 times, most recently
from
196c130 to
39b9be2
Compare
The behaviour of Breeze after some recent changes related to pulling and building images in parallel have been slightly broken. Nothing serious but slightly annoying behaviour: * when starting breeze shell, the image was attempted to be build even if it was not needed (but cache efficiency made it fast enough to not be too annoying (unless we updated to newer python base image * breeze pull command for "latest" branch makes no sense any more - we stopped pushing "latest" image to ghcr.io, we only push cache and "tagged" images. We are now turning --image-tag as required in "pull_image" and when someone specifies latest, error and helpful message is printed * --force-build flag in "shell-related-commands" was not properly propagated to build-image so it did not actually force image building. All those problems are fixed now.
potiuk
force-pushed
the
fix-pull-build-behaviour-of-breeze-after-recent-changes
branch
from
39b9be2 to
90e0d15
Compare
|
Would be nice to merge this one to get fixed non-rebuild experience |
dstandish
approved these changes
Jun 27, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
deleted the
fix-pull-build-behaviour-of-breeze-after-recent-changes
branch
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 29, 2022
The behaviour of Breeze after some recent changes related to pulling and building images in parallel have been slightly broken. Nothing serious but slightly annoying behaviour: * when starting breeze shell, the image was attempted to be build even if it was not needed (but cache efficiency made it fast enough to not be too annoying (unless we updated to newer python base image * breeze pull command for "latest" branch makes no sense any more - we stopped pushing "latest" image to ghcr.io, we only push cache and "tagged" images. We are now turning --image-tag as required in "pull_image" and when someone specifies latest, error and helpful message is printed * --force-build flag in "shell-related-commands" was not properly propagated to build-image so it did not actually force image building. All those problems are fixed now. (cherry picked from commit b678dc2)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour of Breeze after some recent changes related to
pulling and building images in parallel have been slightly broken.
Nothing serious but slightly annoying behaviour:
when starting breeze shell, the image was attempted to be
build even if it was not needed (but cache efficiency made it fast
enough to not be too annoying (unless we updated to newer
python base image
breeze pull command for "latest" branch makes no sense any more -
we stopped pushing "latest" image to ghcr.io, we only push
cache and "tagged" images. We are now turning --image-tag as
required in "pull_image" and when someone specifies latest,
error and helpful message is printed
--force-build flag in "shell-related-commands" was not
properly propagated to build-image so it did not actually
force image building.
All those problems are fixed now.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.