Handle "workflow_run" event properly in selective-check #24656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs #24659 merged to succeed |
Unfortunately testing workflow_run is a bit difficult because the changes are only effective after merging them. Fixing (hopefully) yet another mistake in the workflow run where commit hash was passed as event name (?) We are going to handle "workflow_run" as valid event type so this should now work without passing any event.
potiuk
force-pushed
the
add-workflow-run-as-possible-event-to-handle
branch
from
394386c to
aabed94
Compare
mik-laj
approved these changes
Jun 26, 2022
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 29, 2022
Unfortunately testing workflow_run is a bit difficult because the changes are only effective after merging them. Fixing (hopefully) yet another mistake in the workflow run where commit hash was passed as event name (?) We are going to handle "workflow_run" as valid event type so this should now work without passing any event. (cherry picked from commit e83e7c8)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately testing workflow_run is a bit difficult because
the changes are only effective after merging them.
Fixing (hopefully) yet another mistake in the workflow run where
commit hash was passed as event name (?)
We are going to handle "workflow_run" as valid event type so this
should now work without passing any event.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.