Add test_connection method to Databricks hook #24617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
reviewed
Jun 23, 2022
pankajastro
reviewed
Jun 23, 2022
5 tasks
phanikumv
force-pushed
the
enable_databricks_test_conn
branch
from
09ba2d9 to
b97106d
Compare
pankajastro
approved these changes
Jun 24, 2022
ephraimbuddy
approved these changes
Jun 24, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
ashb
reviewed
Jun 24, 2022
kaxil
approved these changes
Jun 24, 2022
phanikumv
force-pushed
the
enable_databricks_test_conn
branch
from
b97106d to
280ac31
Compare
95 tasks
alexott
reviewed
Jul 16, 2022
| @@ -52,6 +52,8 @@ | |||
|
|
|||
| RUN_LIFE_CYCLE_STATES = ['PENDING', 'RUNNING', 'TERMINATING', 'TERMINATED', 'SKIPPED', 'INTERNAL_ERROR'] | |||
|
|
|||
| LIST_ZONES_ENDPOINT = ('GET', 'api/2.0/clusters/list-zones') | |||
There was a problem hiding this comment.
That was not very good choice as it's only available on AWS, and will fail on Azure & GCP databricks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the test button on the airflow UI for testing whether the Databricks connection works using the connection params filled by the user
cc @kaxil @potiuk
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.