Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LOAD_DEFAULT_CONNECTIONS env var to database config section in CI #24536

Merged
merged 1 commit into from
Jun 18, 2022

Conversation

josh-fell
Copy link
Contributor

As of 2.3 the load_default_connections config was moved from "core" to a new "database" section. Currently when spinning up Airflow in Breeze a DeprecationWarning is displayed for this config:

Starting Airflow

DB: postgresql+psycopg2://postgres:***@postgres/airflow
[2022-06-18 03:05:09,528] {db.py:1471} INFO - Creating tables
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
/opt/airflow/airflow/configuration.py:526 DeprecationWarning: The load_default_connections option in [core] has been moved to the load_default_connections option in [database] - the old setting has been used, but please update your config.
Initialization done

Likely not all of the changes in this PR directly affect the DeprecationWarning thrown when using the breeze start-airflow command, but for the sake of due diligence, the remaining environment variables of AIRFLOW__CORE__LOAD_DEFAULT_CONNECTIONS have been updated to AIRFLOW__DATABASE__LOAD_DEFAULT_CONNECTIONS.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@potiuk potiuk merged commit fe105f8 into apache:main Jun 18, 2022
potiuk pushed a commit to potiuk/airflow that referenced this pull request Jun 29, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.3 milestone Jun 30, 2022
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 1, 2022
@josh-fell josh-fell deleted the ci-load-default-conns branch July 7, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants