Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Salesforce bulk api #24473

Merged
merged 27 commits into from
Jul 5, 2022

Conversation

ishiis
Copy link
Contributor

@ishiis ishiis commented Jun 15, 2022

Add SalesforceBulkInsertOperator, SalesforceBulkUpdateOperator, SalesforceBulkUpsertOperator and SalesforceBulkDeleteOperator.

These operators allow to access Salesforce Bulk API functions.

closes: #16921


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@ishiis ishiis requested a review from eladkal June 16, 2022 14:44
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all LGTM
left few comments

airflow/providers/salesforce/operators/salesforce_bulk.py Outdated Show resolved Hide resolved
airflow/providers/salesforce/operators/salesforce_bulk.py Outdated Show resolved Hide resolved
airflow/providers/salesforce/operators/salesforce_bulk.py Outdated Show resolved Hide resolved
@ishiis ishiis requested review from josh-fell and eladkal June 22, 2022 11:49
@ishiis ishiis force-pushed the add-salesforce-bulk-operator branch from 1964225 to fe70ea8 Compare June 25, 2022 10:35
@ishiis
Copy link
Contributor Author

ishiis commented Jun 28, 2022

@mariotaddeucci @eladkal @josh-fell
What do you think after my changes? Feel free to comment.

@eladkal
Copy link
Contributor

eladkal commented Jul 4, 2022

@ishiis can you fix conflicts and rebase? I will merge after

@ishiis
Copy link
Contributor Author

ishiis commented Jul 4, 2022

@eladkal I fixed the conflicts.

@eladkal eladkal merged commit b6a2759 into apache:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Salesforce Bulk API
4 participants