Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt to have CI-controlled process of releasing PROD image #24433

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 13, 2022


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@potiuk potiuk requested a review from ephraimbuddy June 13, 2022 23:52
@potiuk potiuk force-pushed the release-dockerhub-image branch from cefa3c4 to 27213a5 Compare June 13, 2022 23:53
@potiuk potiuk changed the title Release dockerhub image First attempt to have CI-controlled process of releasing PROD image Jun 13, 2022
@potiuk potiuk force-pushed the release-dockerhub-image branch from 27213a5 to 427a6b6 Compare June 13, 2022 23:55
@potiuk
Copy link
Member Author

potiuk commented Jun 13, 2022

Hey @jedcunningham @ephraimbuddy - we seem to have the secrets sets (at organisation level but only accesspible to us) so you cannot see them when you query for secrets in repo.

Unfortunately, The only way to check the workflow is to merge it (the workflow must be merged in main so that we can run it).

image

@potiuk potiuk force-pushed the release-dockerhub-image branch from 427a6b6 to c0ba68b Compare June 14, 2022 00:03
@potiuk potiuk requested review from dstandish and eladkal June 14, 2022 07:48
@potiuk
Copy link
Member Author

potiuk commented Jun 14, 2022

:D

.github/workflows/release_dockerhub_image.yml Outdated Show resolved Hide resolved
dev/MANUALLY_BUILDING_IMAGES.md Outdated Show resolved Hide resolved
dev/MANUALLY_BUILDING_IMAGES.md Outdated Show resolved Hide resolved
dev/MANUALLY_BUILDING_IMAGES.md Outdated Show resolved Hide resolved
dev/MANUALLY_BUILDING_IMAGES.md Outdated Show resolved Hide resolved
dev/README_RELEASE_AIRFLOW.md Outdated Show resolved Hide resolved
dev/README_RELEASE_AIRFLOW.md Outdated Show resolved Hide resolved
dev/README_RELEASE_AIRFLOW.md Outdated Show resolved Hide resolved
dev/README_RELEASE_AIRFLOW.md Outdated Show resolved Hide resolved
dev/README_RELEASE_AIRFLOW.md Outdated Show resolved Hide resolved
@potiuk potiuk force-pushed the release-dockerhub-image branch from f94d911 to fadcc09 Compare June 14, 2022 22:48
@potiuk potiuk force-pushed the release-dockerhub-image branch from fadcc09 to c58bc0f Compare June 14, 2022 22:57
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jun 14, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit b79790d into apache:main Jun 15, 2022
@potiuk potiuk deleted the release-dockerhub-image branch June 15, 2022 09:42
potiuk added a commit to potiuk/airflow that referenced this pull request Jun 29, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.3 milestone Jun 30, 2022
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants