Fix instructions on reproducing ci errors #24402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
mik-laj,
jedcunningham and
kaxil
as code owners
potiuk
force-pushed
the
fix-instructions-on-reproducing-ci-errors
branch
3 times, most recently
from
61c492a to
ee4a335
Compare
potiuk
force-pushed
the
fix-instructions-on-reproducing-ci-errors
branch
from
ee4a335 to
809e279
Compare
The old breeze-legacy used to have a possibility of very easy
reproduction of CI failures by executing the right breeze command
that contained the commit hash of the PR being tested. This has
been broken for some time after we migrated to the new breeze,
but finally it was the time when it was needed again.
This PR brings back the capability by:
* addding --image-tag parameters for tests, shell and start-airflow
commands
* if --image-tag is specified, then rather than building the
image, it is pulled using the specified hash
* if --image-tag is specified, the local sources are not mounted
to breeze when started, but the sources already embedded in the
image are used ("skipped" set for --mount-sources).
* new "removed" command value is added to --mount-sources, it
causes breeze command to remove the sources from the image (it
is used when installing airflow during the tests for specified
version (it's automatically used when --use-airflow-version
is used).
potiuk
force-pushed
the
fix-instructions-on-reproducing-ci-errors
branch
from
809e279 to
d04402a
Compare
|
It's possible now to use new breeze to reproduce failures from CI more easily :) |
|
:) ? |
josh-fell
reviewed
Jun 17, 2022
| @@ -173,9 +173,6 @@ function breeze_complete::get_known_values_breeze() { | |||
| -g | --github-repository) | |||
| _breeze_known_values="${_breeze_default_github_repository}" | |||
| ;; | |||
| -s | --github-image-id) | |||
There was a problem hiding this comment.
Should github-image-id also be removed/replaced in _breeze_long_options as well?
There was a problem hiding this comment.
Naaa. That's legacy code. I would not worry too much - we are going to delete it shortly
josh-fell
approved these changes
Jun 17, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 29, 2022
…e#24402) The old breeze-legacy used to have a possibility of very easy reproduction of CI failures by executing the right breeze command that contained the commit hash of the PR being tested. This has been broken for some time after we migrated to the new breeze, but finally it was the time when it was needed again. This PR brings back the capability by: * addding --image-tag parameters for tests, shell and start-airflow commands * if --image-tag is specified, then rather than building the image, it is pulled using the specified hash * if --image-tag is specified, the local sources are not mounted to breeze when started, but the sources already embedded in the image are used ("skipped" set for --mount-sources). * new "removed" command value is added to --mount-sources, it causes breeze command to remove the sources from the image (it is used when installing airflow during the tests for specified version (it's automatically used when --use-airflow-version is used). (cherry picked from commit 7dc794a)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old breeze-legacy used to have a possibility of very easy
reproduction of CI failures by executing the right breeze command
that contained the commit hash of the PR being tested. This has
been broken for some time after we migrated to the new breeze,
but finally it was the time when it was needed again.
This PR brings back the capability by:
commands
image, it is pulled using the specified hash
to breeze when started, but the sources already embedded in the
image are used ("skipped" set for --mount-sources).
causes breeze command to remove the sources from the image (it
is used when installing airflow during the tests for specified
version (it's automatically used when --use-airflow-version
is used).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.