Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #24397

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Update Dockerfile #24397

merged 1 commit into from
Jun 12, 2022

Conversation

kinow
Copy link
Member

@kinow kinow commented Jun 12, 2022

Hi,

Just a typo and a place where I used the ARG value (I used Airflow's Dockerfile as reference for an image at $work / internal).

Thanks!!
Bruno

@kinow kinow requested review from potiuk, ashb and mik-laj as code owners June 12, 2022 07:14
@boring-cyborg boring-cyborg bot added the area:production-image Production image improvements and fixes label Jun 12, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 12, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks!

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jun 12, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 5623a5f into apache:main Jun 12, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 12, 2022

Awesome work, congrats on your first merged pull request!

@kinow kinow deleted the patch-1 branch June 12, 2022 11:04
ephraimbuddy pushed a commit that referenced this pull request Jun 30, 2022
(cherry picked from commit 5623a5f)
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.3 milestone Jun 30, 2022
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Jun 30, 2022
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:bug-fix Changelog: Bug Fixes labels Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:production-image Production image improvements and fixes changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants