Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate lambda sample dag to system test (AIP-47) #24355

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Jun 9, 2022

Migrate lambda sample dag to system test

@vincbeck vincbeck requested a review from mik-laj as a code owner June 9, 2022 18:13
@vincbeck vincbeck changed the title Migrate lambda sample dag to system test Migrate lambda sample dag to system test (AIP-47) Jun 9, 2022
@potiuk
Copy link
Member

potiuk commented Jun 12, 2022

Tests failing

@vincbeck
Copy link
Contributor Author

Yep, currently working on it :)

@vincbeck vincbeck marked this pull request as draft June 13, 2022 19:53
@vincbeck vincbeck force-pushed the vincbeck/system-tests/lambda branch from b2c52b7 to 5f32c39 Compare July 15, 2022 13:20
@vincbeck vincbeck marked this pull request as ready for review July 15, 2022 15:03
@vincbeck
Copy link
Contributor Author

It's now fixed

from airflow import models
from airflow.decorators import task
from airflow.models.baseoperator import chain
from airflow.providers.amazon.aws.operators.aws_lambda import AwsLambdaInvokeFunctionOperator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we handled all the aws_ prefixes in file names? @ferruzzi ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the Git Blame, looks like this was added after that sweep. Thanks for the fix.

@eladkal eladkal merged commit f611b1f into apache:main Jul 15, 2022
@vincbeck vincbeck deleted the vincbeck/system-tests/lambda branch July 18, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants